Skip to content

When re-opening a ResumableBidiRPC set _request_queue_generator to None.#7548

Merged
crwilcox merged 1 commit intogoogleapis:masterfrom
crwilcox:pubsub-transient-error
Mar 22, 2019
Merged

When re-opening a ResumableBidiRPC set _request_queue_generator to None.#7548
crwilcox merged 1 commit intogoogleapis:masterfrom
crwilcox:pubsub-transient-error

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2019
@crwilcox crwilcox requested review from frankyn and tseaver March 22, 2019 22:45
@crwilcox
Copy link
Copy Markdown
Contributor Author

The instance member is internal and a _ was missed here.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2019
Copy link
Copy Markdown
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with a note that this variable is a no-op as far as we can tell.

@crwilcox crwilcox merged commit 0c59689 into googleapis:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants